Do proper clean-up of tmp directories #146
Conversation
There was a problem hiding this comment.
I verified this results in the clean up of the Arduino CLI build folders (arduino-language-servernnnnnnnnn).
The system-includes-nnnnn.clangd files are still left behind. Do you have any ideas about that @cmaglie?
It seems likely these are produced by clangd, but I didn't find any complaints about the files in their issue tracker. I do see people complained about the preamble-nnnnnn.pch files not being cleaned up, so I would expect them to do the same if the more common applications of clangd resulted in zillions of these system-includes-nnnnn.clangd files as happens when using Arduino IDE. This made me think maybe there is something about how Arduino Language Server or Arduino IDE is using clangd that causes them to not be cleaned up.
Anyway, it is perfectly fine if this PR is scoped solely to the clean up of the Arduino CLI sketch build folders, so I wouldn't want the subject of the system-includes-nnnnn.clangd files to block the merge, but we should also consider whether this PR can be considered to fully fix #145
Thanks Cristian!
Please check if the PR fulfills these requirements
before creating one)
What kind of change does this PR introduce?
Do proper cleanup of temporary folders.
What is the current behavior?
Temp directories are not removed after receiving the
shutdownmessage, see #145 for detailsWhat is the new behavior?
The
shutdownmessage is now properly handled and the temp directories are removed.Other information:
Partially resolve #145